Make v2_ mutation prefix configurable
#636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljharvey
force-pushed
the
djh/remove-prefix
branch
from
8829dd6 to
14fd6eb
Compare
danieljharvey
commented
Oct 25, 2024
| @@ -4429,5 +4429,6 @@ | |||
| "varchar": "string" | |||
| } | |||
| }, | |||
| "mutationsVersion": "v2" | |||
| "mutationsVersion": "v2", | |||
| "mutationsPrefix": "" | |||
There was a problem hiding this comment.
Before we added this, all the Postgres tests passed as before, after this, we had to go fix lots of things. Which means it works, which is good.
danieljharvey
commented
Oct 25, 2024
| @@ -51,6 +51,9 @@ pub struct ParsedConfiguration { | |||
| /// Which version of the generated mutation procedures to include in the schema response | |||
| #[serde(default)] | |||
| pub mutations_version: Option<metadata::mutations::MutationsVersion>, | |||
| /// Provide a custom prefix for generated mutation names. Defaults to mutations version. | |||
There was a problem hiding this comment.
The new config. serde(default) means old config that does not include this will get None, so we make sure that keeps old behaviour intact.
danieljharvey
changed the title
v2_ mutation prefix configurable
codedmart
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Pulled from #635 into own PR.
We add
mutations_prefix: Option<String>to v5 configuration. When leftnull(for existing projects), we default tov2_mutation_name, but it can be replaced withhorse_mutation_nameetc.Most people will just want to use it to remove the prefix though, and that is the default for new projects.
mutationsPrefix: ""will get rid of the prefix altogether, which I assume most users would want.How